Improve examples so that they work for small MCUs (e.g. Arduino Uno). #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
haydenroche5
commented
Jan 22, 2024
haydenroche5
commented
- If NOTE_LOWMEM is defined, don't call notecard.setDebugOutputStream. This saves RAM by removing logging strings.
- Don't use notecard.logDebug for application logging (i.e. logging in the .ino files).
haydenroche5
force-pushed
the
uno_example_improvements
branch
from
2fdb44b to
2443d9a
Compare
zfields
reviewed
Jan 24, 2024
| @@ -69,8 +69,14 @@ void setup() | |||
| const size_t usb_timeout_ms = 3000; | |||
| for (const size_t start_ms = millis(); !usbSerial && (millis() - start_ms) < usb_timeout_ms;) | |||
| ; | |||
|
|
|||
| // For low-memory platforms, don't turn on internal Notecard logs. | |||
| #ifndef NOTE_LOWMEM | |||
There was a problem hiding this comment.
this is now NOTE_C_LOW_MEM
haydenroche5
force-pushed
the
uno_example_improvements
branch
from
2443d9a to
09b5d31
Compare
|
@zfields I added the |
zfields
approved these changes
Jan 31, 2024
| notecard.logDebug("INBOUND REQUEST: "); | ||
| notecard.logDebug(JGetString(body, INBOUND_QUEUE_COMMAND_FIELD)); | ||
| notecard.logDebug("\n\n"); | ||
| usbSerial.println("[APP] INBOUND REQUEST: "); |
There was a problem hiding this comment.
s/b usbSerial.print() instead of usbSerial.println()
- If NOTE_LOWMEM is defined, don't call notecard.setDebugOutputStream. This saves RAM by removing logging strings. - Don't use notecard.logDebug for application logging (i.e. logging in the .ino files).
haydenroche5
force-pushed
the
uno_example_improvements
branch
from
09b5d31 to
78b4493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.